From e79a371ddec13c0d9dc1a74c082f790966184996 Mon Sep 17 00:00:00 2001 From: Jannis R Date: Wed, 29 Dec 2021 13:51:37 +0100 Subject: [PATCH] add todos --- p/bvg/index.js | 1 + p/db/index.js | 1 + parse/journey-leg.js | 1 + parse/line.js | 1 + 4 files changed, 4 insertions(+) diff --git a/p/bvg/index.js b/p/bvg/index.js index edce9dbc..4147de5d 100644 --- a/p/bvg/index.js +++ b/p/bvg/index.js @@ -154,6 +154,7 @@ const formatStation = (id) => { } // use the Berlkönig ride sharing service? +// todo: https://github.com/alexander-albers/tripkit/issues/26#issuecomment-825437320 const requestJourneysWithBerlkoenig = ({opt}, query) => { if (('numF' in query) && opt.berlkoenig) { // todo: check if this is still true diff --git a/p/db/index.js b/p/db/index.js index d136cf0b..7dae4bc1 100644 --- a/p/db/index.js +++ b/p/db/index.js @@ -157,6 +157,7 @@ const transformJourneysQuery = ({opt}, query) => { query.trfReq = { jnyCl: opt.firstClass === true ? 1 : 2, + // todo [breaking]: support multiple travelers tvlrProf: [{ type: 'E', redtnCard: opt.loyaltyCard diff --git a/parse/journey-leg.js b/parse/journey-leg.js index dd2eb5aa..32274f94 100644 --- a/parse/journey-leg.js +++ b/parse/journey-leg.js @@ -109,6 +109,7 @@ const parseJourneyLeg = (ctx, pt, date) => { // pt = raw leg res.tripId = pt.jny.jid res.line = pt.jny.line || null // todo [breaking]: don't call parseStationName() here, add parseDirection() hook + // todo: support pt.jny.dirL[] res.direction = pt.jny.dirTxt && profile.parseStationName(ctx, pt.jny.dirTxt) || null if (pt.jny.pos) { diff --git a/parse/line.js b/parse/line.js index a64d119a..a78e97e2 100644 --- a/parse/line.js +++ b/parse/line.js @@ -22,6 +22,7 @@ const parseLine = ({profile}, p) => { // todo: what is p.prodCtx.catCode? if (p.prodCtx && 'string' === typeof p.prodCtx.admin) { + // todo [breaking]: don't trim res.adminCode = p.prodCtx.admin.replace(/-+$/, '') }